Skip to content

Fix console blank filtering threshold parsing - #773

Merged
YukiMatsuzawa merged 2 commits into
systemsomicslab:masterfrom
Fraximov:agent/fix-console-blank-threshold
Sep 4, 2026
Merged

Fix console blank filtering threshold parsing#773
YukiMatsuzawa merged 2 commits into
systemsomicslab:masterfrom
Fraximov:agent/fix-console-blank-threshold

Conversation

@Fraximov

Copy link
Copy Markdown
Contributor

Summary

  • preserve the legacy SampleMaxOverBlankAverage value
  • also apply the console value to FoldChangeForBlankFiltering, which the blank filter reads
  • add a regression test for custom sample-max/blank-average thresholds
  • include the existing console test project in the solution so CI runs the regression test

Root cause

The console parser stored Sample max / blank average only in the legacy property, while alignment filtering reads FoldChangeForBlankFiltering. Both default to 5, hiding the mismatch until a custom threshold is configured.

Validation

  • dotnet test tests/MSDIAL5/MsdialCoreTestAppTests/MsdialCoreTestAppTests.csproj --configuration "Debug vendor unsupported" (5 tests passed)

@Fraximov
Fraximov marked this pull request as ready for review August 19, 2026 08:03
@YukiMatsuzawa

Copy link
Copy Markdown
Contributor

Thanks for the PR! I’ll merge it. Please hang tight for a little while.

@YukiMatsuzawa

Copy link
Copy Markdown
Contributor

Thanks to your contribution, We realized that SampleMaxOverBlankAverage and SampleAverageOverBlankAverage do not appear to be used in practice. I’m planning to replace them with FoldChangeForBlankFiltering and the BlankFiltering enum. Thank you!

@YukiMatsuzawa
YukiMatsuzawa merged commit 6276c95 into systemsomicslab:master Sep 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants